build: add PGH003 and PGH004, add types-colorama#1517
Merged
Lee-W merged 1 commit intocommitizen-tools:refactorsfrom Jun 9, 2025
Merged
build: add PGH003 and PGH004, add types-colorama#1517Lee-W merged 1 commit intocommitizen-tools:refactorsfrom
Lee-W merged 1 commit intocommitizen-tools:refactorsfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1517 +/- ##
=============================================
+ Coverage 97.92% 97.96% +0.03%
=============================================
Files 58 58
Lines 2704 2703 -1
=============================================
Hits 2648 2648
+ Misses 56 55 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
commented
Jun 8, 2025
Comment on lines
55
to
+56
| if getattr(Template, "substitute", None): | ||
| return message_template.substitute(**answers) # type: ignore | ||
| return message_template.substitute(**answers) # type: ignore[attr-defined,no-any-return] # pragma: no cover # TODO: check if we can fix this |
Member
There was a problem hiding this comment.
might need to check the standard string lib 🤔
Lee-W
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related: #1501